Merge remote-tracking branch 'origin/stable' into v2

.gitignore

@@ -8,5 +8,3 @@
 mtg
 coverage.txt
 dist/
-.idea/
-.vscode/

README.md

@@ -514,50 +514,6 @@ This is not very necessary. Keep in mind these rules:
    you can enable `drs` setting.
 9. **If you are not sure, touch nothing!**
 
-## Troubleshooting
-
-### `ip was blacklisted` for clients on the same LAN
-
-If you run mtg at home and a client on the same LAN (for example, your
-phone on the home Wi-Fi) cannot connect, check the proxy logs for a
-message like:
-
-```json
-{"level":"info","ip":"10.0.1.1","logger":"proxy","message":"ip was blacklisted"}
-```
-
-The reason is that the default blocklist (`firehol_level1.netset`)
-includes bogon networks, which covers all RFC1918 ranges
-(`10.0.0.0/8`, `172.16.0.0/12`, `192.168.0.0/16`). Any client
-connecting from such an address is rejected by the blocklist —
-the TCP connection is closed immediately with no response, so
-from the client's point of view nothing loads at all.
-
-There are three ways to resolve it:
-
-1. Disable the blocklist entirely in `config.toml`:
-
-   ```toml
-   [defense.blocklist]
-   enabled = false
-   ```
-
-   Simplest option if the proxy is used only by you and people you trust.
-
-2. Keep the blocklist but swap `firehol_level1` for a narrower list that
-   does not include bogons, for example `firehol_abusers_1d`:
-
-   ```toml
-   [defense.blocklist]
-   enabled = true
-   urls = ["https://iplists.firehol.org/files/firehol_abusers_1d.netset"]
-   ```
-
-3. Connect to the proxy through a public IP or domain name with hairpin
-   NAT (`MASQUERADE`) on your router. mtg will then see the client with
-   its public address and the blocklist will not match. This is more
-   work to set up but preserves full blocklist protection.
-
 ## Metrics
 
 Out of the box, mtg works with

contrib/sni-router/Caddyfile

@@ -1,30 +0,0 @@
-{
-	# Caddy sits behind HAProxy which passes raw TLS through on :8443.
-	# ACME HTTP-01 challenges arrive on :80 via HAProxy's acl passthrough.
-	http_port 80
-	https_port 8443
-
-	# HAProxy forwards connections to :8443 with a PROXY protocol v2
-	# header (see haproxy.cfg `send-proxy-v2`).  The proxy_protocol
-	# listener wrapper strips the header and exposes the real client IP
-	# to Caddy's access log.  The `tls` wrapper must follow so that TLS
-	# is terminated on the unwrapped connection.
-	#
-	# `allow` lists the networks permitted to send PROXY headers.  These
-	# ranges cover docker compose's default bridge networks; tighten
-	# them if you pin a specific subnet in docker-compose.yml.
-	servers :8443 {
-		listener_wrappers {
-			proxy_protocol {
-				timeout 5s
-				allow 10.0.0.0/8 172.16.0.0/12 192.168.0.0/16
-			}
-			tls
-		}
-	}
-}
-
-{$DOMAIN} {
-	root * /srv
-	file_server
-}

contrib/sni-router/README.md

@@ -1,89 +0,0 @@
-# SNI-routing deployment for mtg
-
-A turnkey `docker compose` setup that puts an SNI-aware TCP router
-(HAProxy) in front of mtg **and** a real web server (Caddy with
-automatic HTTPS).
-
-## Why
-
-Modern DPI systems actively probe suspected proxies.  If the server
-closes the connection or returns something unexpected, the IP gets
-flagged.  With this setup:
-
-- **Telegram clients** connect to port 443, HAProxy sees the configured
-  SNI and routes them to mtg (FakeTLS).
-- **Everything else** (browsers, DPI probes, scanners) is routed to
-  Caddy, which responds with a real Let's Encrypt certificate and serves
-  genuine web content.
-
-Because your domain's DNS points to this server, the SNI/IP match is
-natural and passive DPI has nothing to flag.
-
-## Quick start
-
-```bash
-# 1. Point your domain's DNS A/AAAA record to this server's IP.
-
-# 2. Generate an mtg secret:
-docker run --rm nineseconds/mtg:2 generate-secret --hex YOUR_DOMAIN
-
-# 3. Edit the config files:
-#    - mtg-config.toml  →  paste the secret
-#    - haproxy.cfg       →  replace "example.com" in the SNI ACL
-#    - .env or export    →  DOMAIN=your.domain
-
-# 4. (Optional) put your site content into www/
-
-# 5. Start:
-docker compose up -d
-
-# 6. Verify:
-#    - Open https://YOUR_DOMAIN in a browser → you should see the web page
-#    - Configure Telegram with the proxy link from:
-docker compose exec mtg mtg access /config/config.toml
-```
-
-## Real client IPs (PROXY protocol)
-
-HAProxy forwards TCP connections to mtg and Caddy with a PROXY protocol
-v2 header so both backends see the real client IP instead of HAProxy's
-container address.  The three pieces must stay in sync:
-
-- `haproxy.cfg` — `send-proxy-v2` on the `mtg` and `web` backend `server` lines
-- `mtg-config.toml` — `proxy-protocol-listener = true`
-- `Caddyfile` — `listener_wrappers { proxy_protocol { ... } tls }` on `:8443`
-
-If you disable one, disable all three, otherwise the backend will fail
-to parse the connection.
-
-## ACME (Let's Encrypt) notes
-
-HAProxy passes `/.well-known/acme-challenge/` requests on `:80` to
-Caddy so that HTTP-01 validation works out of the box.  Make sure your
-domain's DNS A/AAAA record points to this server before starting.
-
-## Architecture
-
-```
-              ┌──────────────────┐
- :443  ──────>│    HAProxy       │
-              │  (TCP, SNI peek) │
-              └──┬───────────┬───┘
-    SNI match    │           │  default
-                 v           v
-           ┌─────────┐  ┌─────────┐
-           │   mtg    │  │  Caddy  │
-           │ :3128    │  │ :8443   │
-           │ FakeTLS  │  │ real TLS│
-           └─────────┘  └─────────┘
-```
-
-## Files
-
-| File | Purpose |
-|---|---|
-| `docker-compose.yml` | Service definitions |
-| `haproxy.cfg` | SNI routing rules — **edit the domain** |
-| `mtg-config.toml` | mtg proxy config — **paste your secret** |
-| `Caddyfile` | Web server config (auto-HTTPS) |
-| `www/` | Static site content served by Caddy |

contrib/sni-router/docker-compose.yml

@@ -1,54 +0,0 @@
-# SNI-routing deployment: HAProxy (443) -> mtg + real web backend
-#
-# This setup puts an SNI-aware TCP router in front of mtg so that:
-#   - Telegram clients (FakeTLS with the correct SNI) are routed to mtg
-#   - All other TLS traffic (including DPI probes) reaches the real web
-#     server, which responds with a genuine certificate
-#
-# The result: active probes see a real website; passive DPI sees matching
-# SNI/IP because the domain resolves to this server's IP.
-#
-# Quick start:
-#   1. Set YOUR_DOMAIN below (and in mtg-config.toml)
-#   2. docker compose up -d
-#   3. mtg generate-secret YOUR_DOMAIN   -> put it in mtg-config.toml
-#   4. docker compose restart mtg
-#
-# See BEST_PRACTICES.md and the project wiki for background.
-
-services:
-  haproxy:
-    image: haproxy:lts-alpine
-    ports:
-      - "443:443"
-      - "80:80"
-    volumes:
-      - ./haproxy.cfg:/usr/local/etc/haproxy/haproxy.cfg:ro
-    depends_on:
-      - mtg
-      - web
-    restart: unless-stopped
-
-  mtg:
-    image: nineseconds/mtg:2
-    volumes:
-      - ./mtg-config.toml:/config/config.toml:ro
-    expose:
-      - "3128"
-    restart: unless-stopped
-
-  web:
-    image: caddy:alpine
-    volumes:
-      - ./Caddyfile:/etc/caddy/Caddyfile:ro
-      - caddy_data:/data
-      - ./www:/srv:ro
-    expose:
-      - "80"
-      - "8443"
-    environment:
-      DOMAIN: ${DOMAIN:-example.com}
-    restart: unless-stopped
-
-volumes:
-  caddy_data:

contrib/sni-router/haproxy.cfg

@@ -1,62 +0,0 @@
-# HAProxy SNI router — Layer 4 (TCP mode)
-#
-# Inspects the SNI in the TLS ClientHello and routes traffic:
-#   - SNI matching the mtg secret domain  ->  mtg (FakeTLS / MTProto)
-#   - Everything else                      ->  real web backend (Caddy)
-#
-# Because routing happens before TLS termination, each backend sees the
-# raw ClientHello and handles TLS itself.  The real web backend therefore
-# presents a genuine certificate to any probe or browser.
-
-global
-    log stdout format raw local0 info
-    maxconn 4096
-
-defaults
-    log     global
-    mode    tcp
-    option  tcplog
-    timeout connect 5s
-    timeout client  60s
-    timeout server  60s
-
-# --- HTTP :80 — ACME challenges + redirect -----------------------------------
-
-frontend http
-    bind *:80
-    mode http
-
-    # Let Caddy answer ACME HTTP-01 challenges for Let's Encrypt.
-    acl is_acme path_beg /.well-known/acme-challenge/
-    use_backend web_acme if is_acme
-
-    http-request redirect scheme https code 301
-
-# --- TLS :443 — SNI-based routing -------------------------------------------
-
-frontend tls
-    bind *:443
-    tcp-request inspect-delay 5s
-    tcp-request content accept if { req_ssl_hello_type 1 }
-
-    # Route Telegram clients to mtg.
-    # Replace "example.com" with the domain from your mtg secret.
-    use_backend mtg if { req_ssl_sni -i example.com }
-
-    default_backend web
-
-backend mtg
-    # send-proxy-v2 prepends a PROXY protocol v2 header so mtg sees the
-    # real client IP instead of HAProxy's.  mtg must have
-    # `proxy-protocol-listener = true` in its config.
-    server mtg mtg:3128 send-proxy-v2
-
-backend web
-    # send-proxy-v2 prepends a PROXY protocol v2 header so Caddy logs the
-    # real client IP instead of HAProxy's.  Caddy must enable the
-    # proxy_protocol listener wrapper on :8443 (see Caddyfile).
-    server web web:8443 send-proxy-v2
-
-backend web_acme
-    mode http
-    server web web:80

contrib/sni-router/mtg-config.toml

@@ -1,17 +0,0 @@
-# Minimal mtg configuration for the SNI-router setup.
-#
-# 1. Generate a secret:  mtg generate-secret --hex example.com
-# 2. Paste it below.
-# 3. Replace example.com with your actual domain everywhere.
-
-secret = "PASTE_YOUR_SECRET_HERE"
-bind-to = "0.0.0.0:3128"
-
-# HAProxy in front sends PROXY protocol v2 headers so mtg can see the
-# real client IP.  Keep this in sync with haproxy.cfg (`send-proxy-v2`).
-proxy-protocol-listener = true
-
-[defense.anti-replay]
-enabled = true
-max-size = "1mib"
-error-rate = 0.001

contrib/sni-router/www/index.html

@@ -1,5 +0,0 @@
-<!doctype html>
-<html lang="en">
-<head><meta charset="utf-8"><title>Welcome</title></head>
-<body><h1>It works!</h1><p>Replace this with your own content.</p></body>
-</html>

essentials/addresses.go

@@ -25,18 +25,6 @@ var TelegramCoreAddresses = map[int][]string{
 	},
 	203: {
 		"91.105.192.100:443",
-		"[2a0a:f280:0203:a:5000::100]:443",
-	},
-	10001: {
-		"149.154.175.10:443",
-		"[2001:b28:f23d:f001::e]:443",
-	},
-	10002: {
-		"149.154.167.40:443",
-		"[2001:67c:4e8:f002::e]:443",
-	},
-	10003: {
-		"149.154.175.117:443",
-		"[2001:b28:f23d:f003::e]:443",
+		"[2a0a:f280:0203:000a:5000:0000:0000:0100]:443",
 	},
 }

example.config.toml

@@ -204,22 +204,14 @@ proxies = [
 # define a global timeout on establishing of network connections. idle
 # means a timeout on pumping data between sockset when nothing is
 # happening.
+#
+# please be noticed that handshakes have no timeouts intentionally. You can
+# find a reasoning here:
+# https://www.ndss-symposium.org/wp-content/uploads/2020/02/23087-paper.pdf
 [network.timeout]
 tcp = "5s"
 http = "10s"
-idle = "5m"
-handshake = "10s"
-
-# this defines a configuration for TCP keep alives. Default values are taken
-# from Golang default behavior.
-[network.keep-alive]
-disabled = false
-# idle means a time period after which we start sending TCP Keep Alive probes
-idle = "15s"
-# interval is a period between 2 consecutive probes
-interval = "15s"
-# if we miss that many probes, a connection will be considered as a dead one.
-count = 9
+idle = "1m"
 
 # mtg has to mimic real websites. It does not mean domain fronting, it also
 # means that traffic characteristics should be similar to real world traffic.
@@ -316,17 +308,6 @@ download-concurrency = 2
 # A list of URLs in FireHOL format (https://iplists.firehol.org/)
 # You can provider links here (starts with https:// or http://) or
 # path to a local file, but in this case it should be absolute.
-#
-# NOTE: the default list below (firehol_level1.netset) includes bogon
-# networks, and therefore RFC1918 ranges as well (10.0.0.0/8,
-# 172.16.0.0/12, 192.168.0.0/16). If you run mtg on a home/LAN network
-# and connect from a client on the same LAN, that client will be
-# rejected with "ip was blacklisted" and the connection dropped (TCP
-# close, no response). If you see this, you can either disable this section
-# (enabled = false), replace firehol_level1 with a narrower list that
-# does not include bogons (e.g. firehol_abusers_1d), or connect via
-# a public IP/domain with hairpin NAT on your router. See README for
-# details.
 urls = [
     "https://iplists.firehol.org/files/firehol_level1.netset",
     # "/local.file"
@@ -378,11 +359,3 @@ bind-to = "127.0.0.1:3129"
 http-path = "/"
 # prefix for metrics for prometheus
 metric-prefix = "mtg"
-
-[dc]
-dc1 = [
-    "149.154.175.50:443",
-    "149.154.175.54:443",
-    "149.154.175.59:443",
-    "[2001:b28:f23d:f001::a]:443"
-]

go.mod

@@ -4,7 +4,7 @@ go 1.26
 
 require (
 	github.com/OneOfOne/xxhash v1.2.8
-	github.com/alecthomas/kong v1.15.0
+	github.com/alecthomas/kong v1.14.0
 	github.com/alecthomas/units v0.0.0-20240927000941-0f3dac36c52b
 	github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5
 	github.com/babolivier/go-doh-client v0.0.0-20201028162107-a76cff4cb8b6
@@ -28,7 +28,7 @@ require (
 
 require (
 	github.com/beevik/ntp v1.5.0
-	github.com/ncruces/go-dns v1.3.3
+	github.com/ncruces/go-dns v1.3.2
 	github.com/pelletier/go-toml/v2 v2.3.0
 	github.com/pires/go-proxyproto v0.11.0
 	github.com/things-go/go-socks5 v0.1.0

go.sum

@@ -2,8 +2,8 @@ github.com/OneOfOne/xxhash v1.2.8 h1:31czK/TI9sNkxIKfaUfGlU47BAxQ0ztGgd9vPyqimf8
 github.com/OneOfOne/xxhash v1.2.8/go.mod h1:eZbhyaAYD41SGSSsnmcpxVoRiQ/MPUTjUdIIOT9Um7Q=
 github.com/alecthomas/assert/v2 v2.11.0 h1:2Q9r3ki8+JYXvGsDyBXwH3LcJ+WK5D0gc5E8vS6K3D0=
 github.com/alecthomas/assert/v2 v2.11.0/go.mod h1:Bze95FyfUr7x34QZrjL+XP+0qgp/zg8yS+TtBj1WA3k=
-github.com/alecthomas/kong v1.15.0 h1:BVJstKbpO73zKpmIu+m/aLRrNmWwxXPIGTNin9VmLVI=
-github.com/alecthomas/kong v1.15.0/go.mod h1:wrlbXem1CWqUV5Vbmss5ISYhsVPkBb1Yo7YKJghju2I=
+github.com/alecthomas/kong v1.14.0 h1:gFgEUZWu2ZmZ+UhyZ1bDhuutbKN1nTtJTwh19Wsn21s=
+github.com/alecthomas/kong v1.14.0/go.mod h1:wrlbXem1CWqUV5Vbmss5ISYhsVPkBb1Yo7YKJghju2I=
 github.com/alecthomas/repr v0.5.2 h1:SU73FTI9D1P5UNtvseffFSGmdNci/O6RsqzeXJtP0Qs=
 github.com/alecthomas/repr v0.5.2/go.mod h1:Fr0507jx4eOXV7AlPV6AVZLYrLIuIeSOWtW57eE/O/4=
 github.com/alecthomas/units v0.0.0-20240927000941-0f3dac36c52b h1:mimo19zliBX/vSQ6PWWSL9lK8qwHozUj03+zLoEB8O0=
@@ -48,8 +48,8 @@ github.com/miekg/dns v1.1.51 h1:0+Xg7vObnhrz/4ZCZcZh7zPXlmU0aveS2HDBd0m0qSo=
 github.com/miekg/dns v1.1.51/go.mod h1:2Z9d3CP1LQWihRZUf29mQ19yDThaI4DAYzte2CaQW5c=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
-github.com/ncruces/go-dns v1.3.3 h1:59OV7XoJrTCoUMZjWRVs4GOjtntMTZqiQ5Mn+BT13hk=
-github.com/ncruces/go-dns v1.3.3/go.mod h1:tuzixNY8PY/M7yUzcvRbUaeLs3ifIdydpi5H2bfRU+s=
+github.com/ncruces/go-dns v1.3.2 h1:kBLuUZBgkQ4qF4WDXZRQ4rG0Gk6sLVJQ5tESkWrxUa0=
+github.com/ncruces/go-dns v1.3.2/go.mod h1:tuzixNY8PY/M7yUzcvRbUaeLs3ifIdydpi5H2bfRU+s=
 github.com/panjf2000/ants/v2 v2.12.0 h1:u9JhESo83i/GkZnhfTNuFMMWcNt7mnV1bGJ6FT4wXH8=
 github.com/panjf2000/ants/v2 v2.12.0/go.mod h1:tSQuaNQ6r6NRhPt+IZVUevvDyFMTs+eS4ztZc52uJTY=
 github.com/patrickmn/go-cache v2.1.0+incompatible h1:HRMgzkcYKYpi3C8ajMPV8OFXaaRUnok+kx1WdO15EQc=

internal/cli/doctor.go

@@ -50,12 +50,6 @@ var (
 	tplEDCConnect = template.Must(
 		template.New("").Parse("  ❌ DC {{ .dc }}: {{ .error }}\n"),
 	)
-	tplODCIPConnect = template.Must(
-		template.New("").Parse("    ✅ {{ .ip }}\n"),
-	)
-	tplEDCIPConnect = template.Must(
-		template.New("").Parse("    ❌ {{ .ip }}: {{ .error }}\n"),
-	)
 
 	tplODNSSNIMatch = template.Must(
 		template.New("").Parse("  ✅ IP address {{ .ip }} matches secret hostname {{ .hostname }}\n"),
@@ -103,12 +97,6 @@ func (d *Doctor) Run(cli *CLI, version string) error {
 		conf.Network.Timeout.TCP.Get(10*time.Second),
 		conf.Network.Timeout.HTTP.Get(0),
 		conf.Network.Timeout.Idle.Get(0),
-		net.KeepAliveConfig{
-			Enable:   !conf.Network.KeepAlive.Disabled.Get(false),
-			Idle:     conf.Network.KeepAlive.Idle.Get(0),
-			Interval: conf.Network.KeepAlive.Interval.Get(0),
-			Count:    int(conf.Network.KeepAlive.Count.Get(0)),
-		},
 	)
 
 	fmt.Println("Validate native network connectivity")
@@ -291,15 +279,8 @@ func (d *Doctor) checkNetworkAddresses(ntw mtglib.Network, addresses []string) e
 	for _, addr := range checkAddresses {
 		conn, err = ntw.DialContext(ctx, "tcp", addr)
 		if err != nil {
-			tplEDCIPConnect.Execute(os.Stdout, map[string]any{
-				"error": err,
-				"ip":    addr,
-			})
 			continue
 		}
-		tplODCIPConnect.Execute(os.Stdout, map[string]any{
-			"ip": addr,
-		})
 
 		conn.Close() //nolint: errcheck
 

internal/cli/run_proxy.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"net"
 	"os"
+	"time"
 
 	"github.com/9seconds/mtg/v2/antireplay"
 	"github.com/9seconds/mtg/v2/events"
@@ -50,12 +51,6 @@ func makeNetwork(conf *config.Config, version string) (mtglib.Network, error) {
 		conf.Network.Timeout.TCP.Get(0),
 		conf.Network.Timeout.HTTP.Get(0),
 		conf.Network.Timeout.Idle.Get(0),
-		net.KeepAliveConfig{
-			Enable:   !conf.Network.KeepAlive.Disabled.Get(false),
-			Idle:     conf.Network.KeepAlive.Idle.Get(0),
-			Interval: conf.Network.KeepAlive.Interval.Get(0),
-			Count:    int(conf.Network.KeepAlive.Count.Get(0)),
-		},
 	)
 
 	proxyDialers := make([]mtglib.Network, len(conf.Network.Proxies))
@@ -268,8 +263,7 @@ func runProxy(conf *config.Config, version string) error { //nolint: funlen
 
 		AllowFallbackOnUnknownDC: conf.AllowFallbackOnUnknownDC.Get(false),
 		TolerateTimeSkewness:     conf.TolerateTimeSkewness.Value,
-		IdleTimeout:              conf.Network.Timeout.Idle.Get(mtglib.DefaultIdleTimeout),
-		HandshakeTimeout:         conf.Network.Timeout.Handshake.Get(mtglib.DefaultHandshakeTimeout),
+		IdleTimeout:              conf.Network.Timeout.Idle.Get(time.Minute),
 
 		DoppelGangerURLs:    doppelGangerURLs,
 		DoppelGangerPerRaid: conf.Defense.Doppelganger.Repeats.Get(mtglib.DoppelGangerPerRaid),

internal/config/config.go

@@ -63,14 +63,7 @@ type Config struct {
 			TCP  TypeDuration `json:"tcp"`
 			HTTP TypeDuration `json:"http"`
 			Idle TypeDuration `json:"idle"`
-			Handshake TypeDuration `json:"handshake"`
 		} `json:"timeout"`
-		KeepAlive struct {
-			Disabled TypeBool        `json:"disabled"`
-			Idle     TypeDuration    `json:"idle"`
-			Interval TypeDuration    `json:"interval"`
-			Count    TypeConcurrency `json:"count"`
-		} `json:"keepAlive"`
 		DOHIP   TypeIP         `json:"dohIp"`
 		DNS     TypeDNSURI     `json:"dns"`
 		Proxies []TypeProxyURL `json:"proxies"`
@@ -91,17 +84,6 @@ type Config struct {
 			MetricPrefix TypeMetricPrefix `json:"metricPrefix"`
 		} `json:"prometheus"`
 	} `json:"stats"`
-	DCs struct{
-		DC1 []TypeHostPort `json:"dc1"`
-		DC2 []TypeHostPort `json:"dc2"`
-		DC3 []TypeHostPort `json:"dc3"`
-		DC4 []TypeHostPort `json:"dc4"`
-		DC5 []TypeHostPort `json:"dc5"`
-		DC203 []TypeHostPort `json:"dc203"`
-		DC10001 []TypeHostPort `json:"dc10001"`
-		DC10002[]TypeHostPort `json:"dc10002"`
-		DC10003 []TypeHostPort `json:"dc10003"`
-	} `json:"dc"`
 }
 
 func (c *Config) GetConcurrency(defaultValue uint) uint {

internal/config/parse.go

@@ -58,14 +58,7 @@ type tomlConfig struct {
 			TCP  string `toml:"tcp" json:"tcp,omitempty"`
 			HTTP string `toml:"http" json:"http,omitempty"`
 			Idle string `toml:"idle" json:"idle,omitempty"`
-			Handshake string `toml:"handshake" json:"handshake,omitempty"`
 		} `toml:"timeout" json:"timeout,omitempty"`
-		KeepAlive struct {
-			Disabled bool   `toml:"disabled" json:"disabled,omitempty"`
-			Idle     string `toml:"idle" json:"idle,omitempty"`
-			Interval string `toml:"interval" json:"interval,omitempty"`
-			Count    uint   `toml:"count" json:"count,omitempty"`
-		} `toml:"keep-alive" json:"keepAlive,omitempty"`
 		DOHIP   string   `toml:"doh-ip" json:"dohIp,omitempty"`
 		DNS     string   `toml:"dns" json:"dns,omitempty"`
 		Proxies []string `toml:"proxies" json:"proxies,omitempty"`
@@ -84,17 +77,6 @@ type tomlConfig struct {
 			MetricPrefix string `toml:"metric-prefix" json:"metricPrefix,omitempty"`
 		} `toml:"prometheus" json:"prometheus,omitempty"`
 	} `toml:"stats" json:"stats,omitempty"`
-	DCs struct{
-		DC1 []string `toml:"dc1" json:"dc1,omitempty"`
-		DC2 []string `toml:"dc2" json:"dc2,omitempty"`
-		DC3 []string `toml:"dc3" json:"dc3,omitempty"`
-		DC4 []string `toml:"dc4" json:"dc4,omitempty"`
-		DC5 []string `toml:"dc5" json:"dc5,omitempty"`
-		DC203 []string `toml:"dc203" json:"dc203,omitempty"`
-		DC10001 []string `toml:"dc10001" json:"dc10001,omitempty"`
-		DC10002 []string `toml:"dc10002" json:"dc10002,omitempty"`
-		DC10003 []string `toml:"dc10003" json:"dc10003,omitempty"`
-	} `toml:"dc" json:"dc,omitempty"`
 }
 
 func Parse(rawData []byte) (*Config, error) {

internal/utils/read_config.go

@@ -4,77 +4,9 @@ import (
 	"fmt"
 	"os"
 
-	"github.com/9seconds/mtg/v2/essentials"
 	"github.com/9seconds/mtg/v2/internal/config"
 )
 
-func readCustomDC(cfg *config.Config) {
-	if len(cfg.DCs.DC1) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC1 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[1] = ips
-	}
-	if len(cfg.DCs.DC2) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC2 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[2] = ips
-	}
-	if len(cfg.DCs.DC3) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC3 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[3] = ips
-	}
-	if len(cfg.DCs.DC4) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC4 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[4] = ips
-	}
-	if len(cfg.DCs.DC5) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC5 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[5] = ips
-	}
-	if len(cfg.DCs.DC203) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC203 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[203] = ips
-	}
-
-	if len(cfg.DCs.DC10001) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC10001 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[10001] = ips
-	}
-	if len(cfg.DCs.DC10002) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC10002 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[10002] = ips
-	}
-	if len(cfg.DCs.DC10003) > 0 {
-		var ips []string
-		for _, addr := range cfg.DCs.DC10003 {
-			ips = append(ips, addr.Value)
-		}
-		essentials.TelegramCoreAddresses[10003] = ips
-	}
-}
-
 func ReadConfig(path string) (*config.Config, error) {
 	content, err := os.ReadFile(path)
 	if err != nil {
@@ -90,7 +22,5 @@ func ReadConfig(path string) (*config.Config, error) {
 		return nil, fmt.Errorf("invalid config: %w", err)
 	}
 
-	readCustomDC(conf)
-
 	return conf, nil
 }

mtglib/init.go

@@ -77,13 +77,8 @@ const (
 	// DefaultIdleTimeout is a default timeout for closing a connection in case of
 	// idling.
 	//
-	// Set to 5 minutes to survive typical mobile sleep periods (2-5 min) and
-	// avoid racing with MTProto ping_delay_disconnect (~60s interval).
-	DefaultIdleTimeout = 5 * time.Minute
-
-	// DefaultHandshakeTimeout defines a time period during which the
-	// all handshake ceremonies must be completed.
-	DefaultHandshakeTimeout = 10 * time.Second
+	// Deprecated: no longer in use because of changed TCP relay algorithm.
+	DefaultIdleTimeout = time.Minute
 
 	// DefaultTolerateTimeSkewness is a default timeout for time skewness on a
 	// faketls timeout verification.

mtglib/internal/tls/fake/client_side.go

@@ -6,7 +6,6 @@ import (
 	"crypto/sha256"
 	"crypto/subtle"
 	"encoding/binary"
-	"errors"
 	"fmt"
 	"io"
 	"net"
@@ -21,19 +20,12 @@ const (
 	// record_type(1) + version(2) + size(2) + handshake_type(1) + uint24_length(3) + client_version(2)
 	RandomOffset = 1 + 2 + 2 + 1 + 3 + 2
 
-	// https://datatracker.ietf.org/doc/html/rfc8701#name-grease-values
-	// https://medium.com/asecuritysite-when-bob-met-alice/in-cybersecurity-what-is-grease-9f8850558dea
-	GreaseMask      = 0x0f0f
-	GreaseValueType = 0x0a0a
-
 	sniDNSNamesListType = 0
 )
 
 var (
 	emptyRandom = [RandomLen]byte{}
 	extTypeSNI  = [2]byte{}
-
-	ErrCannotFindCipher = errors.New("cannot find a cipher")
 )
 
 type ClientHello struct {
@@ -48,6 +40,11 @@ func ReadClientHello(
 	hostname string,
 	tolerateTimeSkewness time.Duration,
 ) (*ClientHello, error) {
+	if err := conn.SetReadDeadline(time.Now().Add(ClientHelloReadTimeout)); err != nil {
+		return nil, fmt.Errorf("cannot set read deadline: %w", err)
+	}
+	defer conn.SetReadDeadline(resetDeadline) //nolint: errcheck
+
 	// This is how FakeTLS is organized:
 	//  1. We create sha256 HMAC with a given secret
 	//  2. We dump there a whole TLS frame except of the fact that random
@@ -133,27 +130,16 @@ func parseHandshake(r io.Reader) (*ClientHello, error) {
 
 	cipherSuiteLen := int64(binary.BigEndian.Uint16(header[:]))
 
-	// Pick the first non-GREASE cipher suite from the list.
-	// Real TLS servers never select GREASE values (RFC 8701, pattern 0x?a?a),
-	// so echoing them back is a trivial DPI fingerprint.
-	// cipherSuiteLen is in bytes; each cipher suite is 2 bytes.
-	for range cipherSuiteLen / 2 {
+	// we do not care about picking up any cipher. we pick the first one,
+	// so it is always should be present.
 	if _, err := io.ReadFull(r, header[:]); err != nil {
-			return nil, fmt.Errorf("cannot read cipher suite: %w", err)
+		return nil, fmt.Errorf("cannot read first cipher suite: %w", err)
 	}
 
-		if hello.CipherSuite != 0 {
-			// do not forget we have to scan until the end
-			continue
-		}
+	hello.CipherSuite = binary.BigEndian.Uint16(header[:])
 
-		if cs := binary.BigEndian.Uint16(header[:]); cs&GreaseMask != GreaseValueType {
-			hello.CipherSuite = cs
-		}
-	}
-
-	if hello.CipherSuite == 0 {
-		return nil, ErrCannotFindCipher
+	if _, err := io.CopyN(io.Discard, r, cipherSuiteLen-2); err != nil {
+		return nil, fmt.Errorf("cannot skip remaining cipher suites: %w", err)
 	}
 
 	if _, err := io.ReadFull(r, header[:1]); err != nil {

mtglib/internal/tls/fake/client_side_snapshot_test.go

@@ -12,6 +12,7 @@ import (
 	"github.com/9seconds/mtg/v2/mtglib"
 	"github.com/9seconds/mtg/v2/mtglib/internal/tls/fake"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 )
@@ -70,6 +71,11 @@ func (suite *ParseClientHelloSnapshotTestSuite) makeConn(data []byte) *parseClie
 		readBuf: readBuf,
 	}
 
+	connMock.
+		On("SetReadDeadline", mock.AnythingOfType("time.Time")).
+		Twice().
+		Return(nil)
+
 	return connMock
 }
 

mtglib/internal/tls/fake/client_side_test.go

@@ -2,9 +2,9 @@ package fake_test
 
 import (
 	"bytes"
-	cryptotls "crypto/tls"
 	"encoding/binary"
 	"encoding/json"
+	"errors"
 	"io"
 	"os"
 	"testing"
@@ -14,6 +14,7 @@ import (
 	"github.com/9seconds/mtg/v2/mtglib"
 	"github.com/9seconds/mtg/v2/mtglib/internal/tls"
 	"github.com/9seconds/mtg/v2/mtglib/internal/tls/fake"
+	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 )
@@ -52,6 +53,11 @@ func (suite *ParseClientHelloTestSuite) SetupTest() {
 	suite.connMock = &parseClientHelloConnMock{
 		readBuf: suite.readBuf,
 	}
+
+	suite.connMock.
+		On("SetReadDeadline", mock.AnythingOfType("time.Time")).
+		Twice().
+		Return(nil)
 }
 
 func (suite *ParseClientHelloTestSuite) TearDownTest() {
@@ -63,11 +69,23 @@ type ParseClientHello_TLSHeaderTestSuite struct {
 }
 
 func (suite *ParseClientHello_TLSHeaderTestSuite) TestEmpty() {
+	suite.connMock.ExpectedCalls = []*mock.Call{}
+	suite.connMock.
+		On("SetReadDeadline", mock.AnythingOfType("time.Time")).
+		Once().
+		Return(errors.New("fail"))
+
 	_, err := fake.ReadClientHello(suite.connMock, suite.secret.Key[:], suite.secret.Host, TolerateTime)
-	suite.ErrorContains(err, "cannot read client hello")
+	suite.ErrorContains(err, "fail")
 }
 
 func (suite *ParseClientHello_TLSHeaderTestSuite) TestNothing() {
+	suite.connMock.ExpectedCalls = []*mock.Call{}
+	suite.connMock.
+		On("SetReadDeadline", mock.AnythingOfType("time.Time")).
+		Twice().
+		Return(nil)
+
 	_, err := fake.ReadClientHello(suite.connMock, suite.secret.Key[:], suite.secret.Host, TolerateTime)
 	suite.ErrorIs(err, io.EOF)
 }
@@ -216,13 +234,12 @@ func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotReadCipherSuiteLe
 }
 
 func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotReadFirstCipherSuite() {
-	body := make([]byte, 2+fake.RandomLen+1+2+1) // cipherSuiteLen=2 but only 1 byte available
-	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1:], 2)
+	body := make([]byte, 2+fake.RandomLen+1+2)
 
 	suite.writeBody(body)
 
 	_, err := fake.ReadClientHello(suite.connMock, suite.secret.Key[:], suite.secret.Host, TolerateTime)
-	suite.ErrorContains(err, "cannot read cipher suite")
+	suite.ErrorContains(err, "cannot read first cipher suite")
 }
 
 func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotSkipRemainingCipherSuites() {
@@ -232,27 +249,12 @@ func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotSkipRemainingCiph
 	suite.writeBody(body)
 
 	_, err := fake.ReadClientHello(suite.connMock, suite.secret.Key[:], suite.secret.Host, TolerateTime)
-	suite.ErrorContains(err, "cannot read cipher suite")
-}
-
-func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotFindCipher() {
-	// All cipher suites are GREASE values — must return ErrCannotFindCipher.
-	body := make([]byte, 2+fake.RandomLen+1+2+4+1)
-	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1:], 4)
-	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1+2:], 0x0a0a)
-	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1+2+2:], 0x1a1a)
-	body[2+fake.RandomLen+1+2+4] = 1
-
-	suite.writeBody(body)
-
-	_, err := fake.ReadClientHello(suite.connMock, suite.secret.Key[:], suite.secret.Host, TolerateTime)
-	suite.ErrorIs(err, fake.ErrCannotFindCipher)
+	suite.ErrorContains(err, "cannot skip remaining cipher suites")
 }
 
 func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotReadCompressionMethodsLength() {
 	body := make([]byte, 2+fake.RandomLen+1+2+2)
 	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1:], 2)
-	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1+2:], cryptotls.TLS_AES_128_GCM_SHA256)
 
 	suite.writeBody(body)
 
@@ -263,7 +265,6 @@ func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotReadCompressionMe
 func (suite *ParseClientHelloHandshakeBodyTestSuite) TestCannotSkipCompressionMethods() {
 	body := make([]byte, 2+fake.RandomLen+1+2+2+1)
 	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1:], 2)
-	binary.BigEndian.PutUint16(body[2+fake.RandomLen+1+2:], cryptotls.TLS_AES_128_GCM_SHA256)
 	body[2+fake.RandomLen+1+2+2] = 1
 
 	suite.writeBody(body)
@@ -299,7 +300,6 @@ func (suite *ParseClientHelloSNITestSuite) writeExtensions(extensions []byte) {
 	// cipherSuite(2) + compressionLen(1) + compression(1) = 41
 	body := make([]byte, 41)
 	binary.BigEndian.PutUint16(body[35:], 2)
-	binary.BigEndian.PutUint16(body[37:], cryptotls.TLS_AES_128_GCM_SHA256)
 	body[39] = 1
 
 	suite.readBuf.Write(body)
@@ -478,6 +478,11 @@ func (s *ParseClientHelloFragmentedTestSuite) makeConn(data []byte) *parseClient
 		readBuf: readBuf,
 	}
 
+	connMock.
+		On("SetReadDeadline", mock.AnythingOfType("time.Time")).
+		Twice().
+		Return(nil)
+
 	return connMock
 }
 

mtglib/internal/tls/fake/init.go

@@ -2,6 +2,15 @@ package fake
 
 import (
 	"errors"
+	"time"
 )
 
-var ErrBadDigest = errors.New("incorrect client random")
+const (
+	ClientHelloReadTimeout = 5 * time.Second
+)
+
+var (
+	resetDeadline time.Time
+
+	ErrBadDigest = errors.New("incorrect client random")
+)

mtglib/internal/tls/fake/server_side_test.go

@@ -58,7 +58,7 @@ func (suite *SendServerHelloTestSuite) TestRecordStructure() {
 	recordType, length, err := tls.ReadRecord(suite.buf, &rec)
 	suite.NoError(err)
 	suite.Equal(byte(tls.TypeApplicationData), recordType)
-	suite.GreaterOrEqual(length, int64(2500))
+	suite.Greater(length, int64(2500))
 
 	suite.Empty(suite.buf.Bytes())
 }

mtglib/internal/tls/fake/testdata/client-hello-ok-grease-first.json

@@ -1,8 +0,0 @@
-{
-  "time": 1617181365,
-  "random": "w4TaDfYg/aUKdx1oi68vxMKvHJczRNvtRRppLETzeNE=",
-  "sessionId": "St2BZ2uHMFn3B2trD1jfdtpjoJOOg6JBeLhFcyCMCq4=",
-  "host": "storage.googleapis.com",
-  "cipherSuite": 4867,
-  "full": "FgMBAgIBAAH+AwPDhNoN9iD9pQp3HWiLry/Ewq8clzNE2+1FGmksRPN40SBK3YFna4cwWfcHa2sPWN922mOgk46DokF4uEVzIIwKrgA2WloTAxMBEwLALMArwCTAI8AKwAnMqcAwwC/AKMAnwBTAE8yoAJ0AnAA9ADwANQAvwAjAEgAKAQABf/8BAAEAAAAAGwAZAAAWc3RvcmFnZS5nb29nbGVhcGlzLmNvbQAXAAAADQAYABYEAwgEBAEFAwIDCAUIBQUBCAYGAQIBAAUABQEAAAAAM3QAAAASAAAAEAAwAC4CaDIFaDItMTYFaDItMTUFaDItMTQIc3BkeS8zLjEGc3BkeS8zCGh0dHAvMS4xAAsAAgEAADMAJgAkAB0AIAf+6C8fSRJSAC7CyUvdR9kDclNR9KLCsCFHpVZ3bC8iAC0AAgEBACsACQgDBAMDAwIDAQAKAAoACAAdABcAGAAZABUAoQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
-}

mtglib/proxy.go

@@ -28,7 +28,6 @@ type Proxy struct {
 	allowFallbackOnUnknownDC    bool
 	tolerateTimeSkewness        time.Duration
 	idleTimeout                 time.Duration
-	handshakeTimeout            time.Duration
 	domainFrontingPort          int
 	domainFrontingIP            string
 	domainFrontingProxyProtocol bool
@@ -67,11 +66,6 @@ func (p *Proxy) ServeConn(conn essentials.Conn) {
 	ctx := newStreamContext(p.ctx, p.logger, conn)
 	defer ctx.Close()
 
-	if err := ctx.clientConn.SetDeadline(time.Now().Add(p.handshakeTimeout)); err != nil {
-		ctx.logger.WarningError("cannot set handshake timeout", err)
-		return
-	}
-
 	stop := context.AfterFunc(ctx, func() {
 		ctx.Close()
 	})
@@ -103,11 +97,6 @@ func (p *Proxy) ServeConn(conn essentials.Conn) {
 		return
 	}
 
-	if err := ctx.clientConn.SetDeadline(time.Time{}); err != nil {
-		ctx.logger.WarningError("cannot set deadline", err)
-		return
-	}
-
 	if err := p.doTelegramCall(ctx); err != nil {
 		ctx.logger.WarningError("cannot dial to telegram", err)
 		return
@@ -357,7 +346,6 @@ func NewProxy(opts ProxyOpts) (*Proxy, error) {
 		domainFrontingIP:         opts.DomainFrontingIP,
 		tolerateTimeSkewness:     opts.getTolerateTimeSkewness(),
 		idleTimeout:              opts.getIdleTimeout(),
-		handshakeTimeout:         opts.getHandshakeTimeout(),
 		allowFallbackOnUnknownDC: opts.AllowFallbackOnUnknownDC,
 		telegram:                 tg,
 		doppelGanger: doppel.NewGanger(

mtglib/proxy_opts.go

@@ -70,12 +70,6 @@ type ProxyOpts struct {
 	// This is an optional setting.
 	IdleTimeout time.Duration
 
-	// HandshakeTimeout is a timeout during which all handshake ceremonies must
-	// be completed, otherwise this process will be aborted
-	//
-	// This is an optional setting.
-	HandshakeTimeout time.Duration
-
 	// TolerateTimeSkewness is a time boundary that defines a time range where
 	// faketls timestamp is acceptable.
 	//
@@ -221,17 +215,9 @@ func (p ProxyOpts) getPreferIP() string {
 	return p.PreferIP
 }
 
-func (p ProxyOpts) getHandshakeTimeout() time.Duration {
-	if p.HandshakeTimeout == 0 {
-		return DefaultHandshakeTimeout
-	}
-
-	return p.HandshakeTimeout
-}
-
 func (p ProxyOpts) getIdleTimeout() time.Duration {
 	if p.IdleTimeout == 0 {
-		return DefaultIdleTimeout
+		return time.Minute
 	}
 
 	return p.IdleTimeout

network/init.go

@@ -36,22 +36,8 @@ const (
 
 	// DefaultTCPKeepAlivePeriod defines a time period between 2 consequitive
 	// probes.
-	//
-	// Deprecated: use DefaultKeepAliveIdle and DefaultKeepAliveInterval instead.
 	DefaultTCPKeepAlivePeriod = 10 * time.Second
 
-	// DefaultKeepAliveIdle is the time a connection must be idle before
-	// the first keepalive probe is sent.
-	DefaultKeepAliveIdle = 30 * time.Second
-
-	// DefaultKeepAliveInterval is the time between consecutive keepalive
-	// probes.
-	DefaultKeepAliveInterval = 10 * time.Second
-
-	// DefaultKeepAliveCount is the number of unacknowledged probes before
-	// the connection is considered dead.
-	DefaultKeepAliveCount = 3
-
 	// ProxyDialerOpenThreshold is used for load balancing SOCKS5 dialer only.
 	//
 	// This dialer uses circuit breaker with of 3 stages: OPEN, HALF_OPEN and

network/sockopts.go

@@ -20,13 +20,8 @@ func SetServerSocketOptions(conn net.Conn, bufferSize int) error {
 }
 
 func setCommonSocketOptions(conn *net.TCPConn) error {
-	if err := applyKeepAlive(conn, net.KeepAliveConfig{
-		Enable:   true,
-		Idle:     DefaultKeepAliveIdle,
-		Interval: DefaultKeepAliveInterval,
-		Count:    DefaultKeepAliveCount,
-	}); err != nil {
-		return fmt.Errorf("cannot configure TCP keepalive: %w", err)
+	if err := conn.SetKeepAlivePeriod(DefaultTCPKeepAlivePeriod); err != nil {
+		return fmt.Errorf("cannot set time period of TCP keepalive probes: %w", err)
 	}
 
 	if err := conn.SetLinger(tcpLingerTimeout); err != nil {

network/sockopts_keepalive.go

@@ -1,11 +0,0 @@
-//go:build !openbsd
-
-package network
-
-import "net"
-
-// applyKeepAlive enables TCP keepalive on conn and applies the per-socket
-// idle/interval/count tuning from cfg.
-func applyKeepAlive(conn *net.TCPConn, cfg net.KeepAliveConfig) error {
-	return conn.SetKeepAliveConfig(cfg) //nolint: wrapcheck
-}

network/sockopts_keepalive_openbsd.go

@@ -1,20 +0,0 @@
-package network
-
-import "net"
-
-// applyKeepAlive enables (or disables) TCP keepalive on conn.
-//
-// OpenBSD has no user-settable per-socket TCP keepalive options: TCP_KEEPIDLE,
-// TCP_KEEPINTVL and TCP_KEEPCNT do not exist on OpenBSD, and Go's
-// (*TCPConn).SetKeepAliveConfig therefore returns ENOPROTOOPT ("protocol not
-// available") for any non-negative Idle/Interval/Count value (see
-// src/net/tcpsockopt_openbsd.go in the Go source tree). Calling
-// SetKeepAliveConfig with mtg's defaults (zero values) breaks every accepted
-// listener connection and every outbound dial on OpenBSD.
-//
-// On OpenBSD we only flip SO_KEEPALIVE on or off; the keepalive timing is
-// controlled system-wide via the sysctl knobs net.inet.tcp.keepidle and
-// net.inet.tcp.keepintvl.
-func applyKeepAlive(conn *net.TCPConn, cfg net.KeepAliveConfig) error {
-	return conn.SetKeepAlive(cfg.Enable) //nolint: wrapcheck
-}

network/sockopts_test.go

@@ -1,93 +0,0 @@
-//go:build linux || darwin
-// +build linux darwin
-
-package network_test
-
-import (
-	"net"
-	"runtime"
-	"syscall"
-	"testing"
-	"time"
-
-	"github.com/9seconds/mtg/v2/network"
-	"github.com/stretchr/testify/require"
-	"golang.org/x/sys/unix"
-)
-
-func tcpKeepIdleOption() int {
-	if runtime.GOOS == "darwin" {
-		return 0x10 // TCP_KEEPALIVE on macOS
-	}
-
-	return 0x4 // TCP_KEEPIDLE on Linux
-}
-
-func TestSetClientSocketOptionsKeepAlive(t *testing.T) {
-	t.Parallel()
-
-	listener, err := net.Listen("tcp", "127.0.0.1:0")
-	require.NoError(t, err)
-	defer func() {
-		err := listener.Close()
-		require.NoError(t, err)
-	}()
-
-	type dialResult struct {
-		conn net.Conn
-		err  error
-	}
-
-	dialDone := make(chan dialResult, 1)
-
-	go func() {
-		c, err := net.Dial("tcp", listener.Addr().String())
-		dialDone <- dialResult{conn: c, err: err}
-	}()
-
-	tcpListener, ok := listener.(*net.TCPListener)
-	require.True(t, ok, "listener must be a *net.TCPListener")
-
-	require.NoError(t, tcpListener.SetDeadline(time.Now().Add(5*time.Second)))
-
-	accepted, err := listener.Accept()
-	require.NoError(t, err)
-	defer func() {
-		err := accepted.Close()
-		require.NoError(t, err)
-	}()
-
-	dr := <-dialDone
-	require.NoError(t, dr.err)
-	defer func() {
-		err := dr.conn.Close()
-		require.NoError(t, err)
-	}()
-
-	err = network.SetClientSocketOptions(accepted, 0)
-	require.NoError(t, err)
-
-	tcpConn := accepted.(*net.TCPConn)
-
-	rawConn, err := tcpConn.SyscallConn()
-	require.NoError(t, err)
-
-	err = rawConn.Control(func(fd uintptr) {
-		val, err := unix.GetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_KEEPALIVE)
-		require.NoError(t, err)
-		require.NotEqual(t, 0, val, "SO_KEEPALIVE should be enabled")
-
-		idle, err := unix.GetsockoptInt(int(fd), syscall.IPPROTO_TCP, tcpKeepIdleOption())
-		require.NoError(t, err)
-		require.Equal(t, int(network.DefaultKeepAliveIdle.Seconds()), idle)
-
-		interval, err := unix.GetsockoptInt(int(fd), syscall.IPPROTO_TCP, unix.TCP_KEEPINTVL)
-		require.NoError(t, err)
-		require.Equal(t, int(network.DefaultKeepAliveInterval.Seconds()), interval)
-
-		count, err := unix.GetsockoptInt(int(fd), syscall.IPPROTO_TCP, unix.TCP_KEEPCNT)
-		require.NoError(t, err)
-		require.Equal(t, network.DefaultKeepAliveCount, count)
-	})
-	require.NoError(t, err)
-}

network/v2/base_http_test.go

@@ -25,7 +25,7 @@ func (suite *BaseHTTPTestSuite) SetupSuite() {
 }
 
 func (suite *BaseHTTPTestSuite) SetupTest() {
-	suite.client = network.New(nil, "mtg/1", 0, 0, 0, network.DefaultKeepAliveConfig).MakeHTTPClient(nil)
+	suite.client = network.New(nil, "mtg/1", 0, 0, 0).MakeHTTPClient(nil)
 }
 
 func (suite *BaseHTTPTestSuite) TestGet() {

network/v2/base_network_test.go

@@ -19,7 +19,7 @@ type BaseNetworkTestSuite struct {
 func (suite *BaseNetworkTestSuite) SetupSuite() {
 	suite.EchoServerTestSuite.SetupSuite()
 
-	suite.net = network.New(nil, "agent", 0, 0, 0, network.DefaultKeepAliveConfig)
+	suite.net = network.New(nil, "agent", 0, 0, 0)
 }
 
 func (suite *BaseNetworkTestSuite) TestDialUnknownNetwork() {

network/v2/init.go

@@ -11,7 +11,6 @@ package network
 
 import (
 	"errors"
-	"net"
 	"time"
 )
 
@@ -27,55 +26,14 @@ const (
 
 	// DefaultTCPKeepAlivePeriod defines a time period between 2 consecuitive
 	// probes.
-	//
-	// Deprecated: use DefaultKeepAliveConfig
 	DefaultTCPKeepAlivePeriod = 10 * time.Second
 
-	// DefaultKeepAliveIdle is the time a connection must be idle before
-	// the first keepalive probe is sent.
-	//
-	// Deprecated: use DefaultKeepAliveConfig
-	DefaultKeepAliveIdle = 30 * time.Second
-
-	// DefaultKeepAliveInterval is the time between consecutive keepalive
-	// probes.
-	//
-	// Deprecated: use DefaultKeepAliveConfig
-	DefaultKeepAliveInterval = 10 * time.Second
-
-	// DefaultKeepAliveCount is the number of unacknowledged probes before
-	// the connection is considered dead.
-	//
-	// Deprecated: use DefaultKeepAliveConfig
-	DefaultKeepAliveCount = 3
-
 	// User Agent to use in HTTP client.
 	UserAgent = "curl/8.5.0"
 
 	// tcpLingerTimeout defines a number of seconds to wait for sending
 	// unacknowledged data.
 	tcpLingerTimeout = 1
-
-	// tcpNotSentLowat limits the amount of unsent data queued in the
-	// kernel write buffer per socket. When the unsent data drops below
-	// this threshold, the socket becomes writable again. This reduces
-	// per-connection memory usage and bufferbloat by applying
-	// back-pressure to the relay loop instead of piling up data in
-	// kernel buffers.
-	tcpNotSentLowat = 128 * 1024
 )
 
-var (
-	ErrCannotDial = errors.New("cannot dial to any address")
-
-	// DefaultKeepAliveConfig defines a default configuration for
-	// keep alive settings. As per official documentation, if keep alive
-	// is enabled, then:
-	//
-	//  Idle = 15 * time.Second
-	//  Interval = 15 * time.Second
-	//  Count = 9
-	DefaultKeepAliveConfig = net.KeepAliveConfig{
-		Enable: true,
-	}
-)
+var ErrCannotDial = errors.New("cannot dial to any address")

network/v2/network.go

@@ -14,7 +14,6 @@ import (
 type network struct {
 	net.Dialer
 
-	keepAliveConfig net.KeepAliveConfig
 	httpTimeout time.Duration
 	idleTimeout time.Duration
 	userAgent   string
@@ -38,7 +37,7 @@ func (n *network) DialContext(ctx context.Context, network, address string) (ess
 
 	tcpConn := conn.(*net.TCPConn)
 
-	return tcpConn, setCommonSocketOptions(tcpConn, n.keepAliveConfig)
+	return tcpConn, setCommonSocketOptions(tcpConn)
 }
 
 func (n *network) MakeHTTPClient(
@@ -72,7 +71,6 @@ func New(
 	tcpTimeout,
 	httpTimeout,
 	idleTimeout time.Duration,
-	keepAliveConfig net.KeepAliveConfig,
 ) mtglib.Network {
 	if dnsResolver == nil {
 		dnsResolver = net.DefaultResolver
@@ -91,6 +89,5 @@ func New(
 		userAgent:   userAgent,
 		idleTimeout: idleTimeout,
 		httpTimeout: httpTimeout,
-		keepAliveConfig: keepAliveConfig,
 	}
 }

network/v2/sockopts.go

@@ -5,9 +5,9 @@ import (
 	"net"
 )
 
-func setCommonSocketOptions(conn *net.TCPConn, keepAliveConfig net.KeepAliveConfig) error {
-	if err := applyKeepAlive(conn, keepAliveConfig); err != nil {
-		return fmt.Errorf("cannot configure TCP keepalive: %w", err)
+func setCommonSocketOptions(conn *net.TCPConn) error {
+	if err := conn.SetKeepAlivePeriod(DefaultTCPKeepAlivePeriod); err != nil {
+		return fmt.Errorf("cannot set time period of TCP keepalive probes: %w", err)
 	}
 
 	if err := conn.SetLinger(tcpLingerTimeout); err != nil {
@@ -23,9 +23,5 @@ func setCommonSocketOptions(conn *net.TCPConn, keepAliveConfig net.KeepAliveConf
 		return fmt.Errorf("cannot setup SO_REUSEADDR/PORT: %w", err)
 	}
 
-	setCongestionControl(rawConn)
-	setTCPUserTimeout(rawConn, keepAliveConfig)
-	setNotSentLowat(rawConn)
-
 	return nil
 }

network/v2/sockopts_congestion.go

@@ -1,20 +0,0 @@
-//go:build linux
-
-package network
-
-import (
-	"syscall"
-
-	"golang.org/x/sys/unix"
-)
-
-// setCongestionControl sets BBR as the TCP congestion control algorithm.
-// BBR provides better throughput over lossy and high-latency links compared
-// to the default cubic, which is especially beneficial for mobile and
-// home internet clients. This is best-effort: silently ignored if the
-// kernel does not have tcp_bbr available.
-func setCongestionControl(conn syscall.RawConn) {
-	conn.Control(func(fd uintptr) { //nolint: errcheck
-		unix.SetsockoptString(int(fd), unix.IPPROTO_TCP, unix.TCP_CONGESTION, "bbr") //nolint: errcheck
-	})
-}

network/v2/sockopts_congestion_stub.go

@@ -1,7 +0,0 @@
-//go:build !linux
-
-package network
-
-import "syscall"
-
-func setCongestionControl(conn syscall.RawConn) {}

network/v2/sockopts_keepalive.go

@@ -1,11 +0,0 @@
-//go:build !openbsd
-
-package network
-
-import "net"
-
-// applyKeepAlive enables TCP keepalive on conn and applies the per-socket
-// idle/interval/count tuning from cfg.
-func applyKeepAlive(conn *net.TCPConn, cfg net.KeepAliveConfig) error {
-	return conn.SetKeepAliveConfig(cfg) //nolint: wrapcheck
-}

network/v2/sockopts_keepalive_openbsd.go

@@ -1,20 +0,0 @@
-package network
-
-import "net"
-
-// applyKeepAlive enables (or disables) TCP keepalive on conn.
-//
-// OpenBSD has no user-settable per-socket TCP keepalive options: TCP_KEEPIDLE,
-// TCP_KEEPINTVL and TCP_KEEPCNT do not exist on OpenBSD, and Go's
-// (*TCPConn).SetKeepAliveConfig therefore returns ENOPROTOOPT ("protocol not
-// available") for any non-negative Idle/Interval/Count value (see
-// src/net/tcpsockopt_openbsd.go in the Go source tree). Calling
-// SetKeepAliveConfig with mtg's defaults (zero values) breaks every accepted
-// listener connection and every outbound dial on OpenBSD.
-//
-// On OpenBSD we only flip SO_KEEPALIVE on or off; the keepalive timing is
-// controlled system-wide via the sysctl knobs net.inet.tcp.keepidle and
-// net.inet.tcp.keepintvl.
-func applyKeepAlive(conn *net.TCPConn, cfg net.KeepAliveConfig) error {
-	return conn.SetKeepAlive(cfg.Enable) //nolint: wrapcheck
-}

network/v2/sockopts_lowat.go

@@ -1,20 +0,0 @@
-//go:build linux || darwin
-
-package network
-
-import (
-	"syscall"
-
-	"golang.org/x/sys/unix"
-)
-
-// setNotSentLowat sets TCP_NOTSENT_LOWAT which limits the amount of
-// unsent data queued in the kernel write buffer. Once unsent data drops
-// below this threshold the socket becomes writable again, applying
-// back-pressure to the relay loop instead of piling up data in kernel
-// buffers. This reduces per-connection memory and bufferbloat.
-func setNotSentLowat(conn syscall.RawConn) {
-	conn.Control(func(fd uintptr) { //nolint: errcheck
-		unix.SetsockoptInt(int(fd), unix.IPPROTO_TCP, unix.TCP_NOTSENT_LOWAT, tcpNotSentLowat) //nolint: errcheck
-	})
-}

network/v2/sockopts_lowat_stub.go

@@ -1,7 +0,0 @@
-//go:build !linux && !darwin
-
-package network
-
-import "syscall"
-
-func setNotSentLowat(conn syscall.RawConn) {}

network/v2/sockopts_test.go

@@ -1,92 +0,0 @@
-//go:build linux || darwin
-// +build linux darwin
-
-package network
-
-import (
-	"net"
-	"runtime"
-	"syscall"
-	"testing"
-	"time"
-
-	"github.com/stretchr/testify/require"
-	"golang.org/x/sys/unix"
-)
-
-func tcpKeepIdleOption() int {
-	if runtime.GOOS == "darwin" {
-		return 0x10 // TCP_KEEPALIVE on macOS
-	}
-
-	return 0x4 // TCP_KEEPIDLE on Linux
-}
-
-func TestSetCommonSocketOptionsKeepAlive(t *testing.T) {
-	t.Parallel()
-
-	listener, err := net.Listen("tcp", "127.0.0.1:0")
-	require.NoError(t, err)
-	defer func() {
-		err := listener.Close()
-		require.NoError(t, err)
-	}()
-
-	type dialResult struct {
-		conn net.Conn
-		err  error
-	}
-
-	dialDone := make(chan dialResult, 1)
-
-	go func() {
-		c, err := net.Dial("tcp", listener.Addr().String())
-		dialDone <- dialResult{conn: c, err: err}
-	}()
-
-	tcpListener, ok := listener.(*net.TCPListener)
-	require.True(t, ok, "listener must be a *net.TCPListener")
-
-	require.NoError(t, tcpListener.SetDeadline(time.Now().Add(5*time.Second)))
-
-	accepted, err := listener.Accept()
-	require.NoError(t, err)
-	defer func() {
-		err := accepted.Close()
-		require.NoError(t, err)
-	}()
-
-	dr := <-dialDone
-	require.NoError(t, dr.err)
-	defer func() {
-		err := dr.conn.Close()
-		require.NoError(t, err)
-	}()
-
-	tcpConn := accepted.(*net.TCPConn)
-
-	err = setCommonSocketOptions(tcpConn, DefaultKeepAliveConfig)
-	require.NoError(t, err)
-
-	rawConn, err := tcpConn.SyscallConn()
-	require.NoError(t, err)
-
-	err = rawConn.Control(func(fd uintptr) {
-		val, err := unix.GetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_KEEPALIVE)
-		require.NoError(t, err)
-		require.NotEqual(t, 0, val, "SO_KEEPALIVE should be enabled")
-
-		idle, err := unix.GetsockoptInt(int(fd), syscall.IPPROTO_TCP, tcpKeepIdleOption())
-		require.NoError(t, err)
-		require.Equal(t, 15, idle, "keepalive idle should match DefaultKeepAliveIdle")
-
-		interval, err := unix.GetsockoptInt(int(fd), syscall.IPPROTO_TCP, unix.TCP_KEEPINTVL)
-		require.NoError(t, err)
-		require.Equal(t, 15, interval, "keepalive interval should match DefaultKeepAliveInterval")
-
-		count, err := unix.GetsockoptInt(int(fd), syscall.IPPROTO_TCP, unix.TCP_KEEPCNT)
-		require.NoError(t, err)
-		require.Equal(t, 9, count, "keepalive count should match DefaultKeepAliveCount")
-	})
-	require.NoError(t, err)
-}

network/v2/sockopts_unix.go

@@ -1,4 +1,5 @@
 //go:build !windows
+// +build !windows
 
 package network
 

network/v2/sockopts_usertimeout.go

@@ -1,48 +0,0 @@
-//go:build linux
-
-package network
-
-import (
-	"net"
-	"syscall"
-	"time"
-
-	"golang.org/x/sys/unix"
-)
-
-// Go runtime defaults for KeepAliveConfig when fields are zero.
-const (
-	goDefaultKeepAliveIdle     = 15 * time.Second
-	goDefaultKeepAliveInterval = 15 * time.Second
-	goDefaultKeepAliveCount    = 9
-)
-
-// setTCPUserTimeout sets TCP_USER_TIMEOUT on a socket. If transmitted
-// data remains unacknowledged for this long, the kernel closes the
-// connection. As recommended by Cloudflare
-// (https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/),
-// the value is computed as: keepidle + keepintvl * keepcnt. This
-// ensures TCP_USER_TIMEOUT and keepalives agree on when to give up.
-// Best-effort: silently ignored if unsupported.
-func setTCPUserTimeout(conn syscall.RawConn, cfg net.KeepAliveConfig) {
-	idle := cfg.Idle
-	if idle == 0 {
-		idle = goDefaultKeepAliveIdle
-	}
-
-	interval := cfg.Interval
-	if interval == 0 {
-		interval = goDefaultKeepAliveInterval
-	}
-
-	count := cfg.Count
-	if count == 0 {
-		count = goDefaultKeepAliveCount
-	}
-
-	timeout := idle + interval*time.Duration(count)
-
-	conn.Control(func(fd uintptr) { //nolint: errcheck
-		unix.SetsockoptInt(int(fd), unix.IPPROTO_TCP, unix.TCP_USER_TIMEOUT, int(timeout.Milliseconds())) //nolint: errcheck
-	})
-}

network/v2/sockopts_usertimeout_stub.go

@@ -1,10 +0,0 @@
-//go:build !linux
-
-package network
-
-import (
-	"net"
-	"syscall"
-)
-
-func setTCPUserTimeout(conn syscall.RawConn, cfg net.KeepAliveConfig) {}

network/v2/sockopts_windows.go

@@ -1,4 +1,5 @@
 //go:build windows
+// +build windows
 
 package network
 

network/v2/socks_proxy_test.go

@@ -66,7 +66,7 @@ func (suite *SocksProxyTestSuite) SetupSuite() {
 	require.NoError(suite.T(), err)
 	suite.authURL = parsed
 
-	suite.baseNetwork = network.New(nil, "mtg", 0, 0, 0, network.DefaultKeepAliveConfig)
+	suite.baseNetwork = network.New(nil, "mtg", 0, 0, 0)
 }
 
 func (suite *SocksProxyTestSuite) TestIncorrectSchema() {