From fbbf9b1634ad8fad24f79090066fbb58bc47b237 Mon Sep 17 00:00:00 2001 From: 9seconds Date: Mon, 4 Nov 2019 21:36:59 +0300 Subject: [PATCH] Get rid of magic constants --- wrappers/stream/faketls.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/wrappers/stream/faketls.go b/wrappers/stream/faketls.go index 7c60a8f..ee1e5f3 100644 --- a/wrappers/stream/faketls.go +++ b/wrappers/stream/faketls.go @@ -19,7 +19,11 @@ var ( fakeTLSWritePrefix = []byte{0x17, 0x03, 0x03} ) -const faketlsMaxChunkSize = 16384 + 24 +const ( + faketlsMaxChunkSize = 16384 + 24 + faketlsRecordTypeApplicationData = 0x17 + faketlsRecordTypeCCS = 0x14 +) type wrapperFakeTLS struct { bufferedReader @@ -106,15 +110,15 @@ func NewFakeTLS(socket conntypes.StreamReadWriteCloser) conntypes.StreamReadWrit faketls.readFunc = func() ([]byte, error) { data := &bytes.Buffer{} buf := [2]byte{} - recordType := byte(0x14) + recordType := byte(faketlsRecordTypeCCS) - for recordType == 0x14 { + for recordType == faketlsRecordTypeCCS { if _, err := io.ReadFull(faketls.parent, buf[:1]); err != nil { return nil, fmt.Errorf("cannot read record type: %w", err) } switch buf[0] { - case 0x14, 0x17: + case faketlsRecordTypeCCS, faketlsRecordTypeApplicationData: recordType = buf[0] default: return nil, fmt.Errorf("incorrect record type %v", buf[0])