Address review: use slices.Clone, simplify concurrent test

- Replace manual make+copy with slices.Clone in Snapshot()
- Remove redundant _ = len(data); Snapshot() call alone is
  sufficient to exercise the lock under -race

mtglib/internal/doppel/scout_conn_collected.go

@@ -1,6 +1,7 @@
 package doppel
 
 import (
+	"slices"
 	"sync"
 	"time"
 )
@@ -43,8 +44,7 @@ func (s *ScoutConnCollected) MarkWrite() {
 // Snapshot returns a copy of the collected data and the write index.
 func (s *ScoutConnCollected) Snapshot() ([]ScoutConnResult, int) {
 	s.mu.Lock()
-	snapshot := make([]ScoutConnResult, len(s.data))
+	snapshot := slices.Clone(s.data)
-	copy(snapshot, s.data)
 	writeIndex := s.writeIndex
 	s.mu.Unlock()
 

mtglib/internal/doppel/scout_conn_collected_test.go

@@ -68,8 +68,8 @@ func (suite *ScoutConnCollectedTestSuite) TestConcurrentAddSnapshot() {
 		defer wg.Done()
 
 		for i := 0; i < 1000; i++ {
-			data, _ := collected.Snapshot()
+			// call Snapshot concurrently to exercise the lock under -race
-			_ = len(data)
+			collected.Snapshot() //nolint:errcheck
 		}
 	}()