Remove clock goroutine

This is a followup for https://github.com/9seconds/mtg/issues/412 it
makes sense to manage timers inplace instead of creating for new
goroutines: saves memory
This commit is contained in:
9seconds
2026-03-29 15:39:33 +02:00
parent 822560bede
commit 0c030646f9
6 changed files with 17 additions and 139 deletions
+10 -17
View File
@@ -4,6 +4,7 @@ import (
"bytes"
"context"
"sync"
"time"
"github.com/9seconds/mtg/v2/essentials"
"github.com/9seconds/mtg/v2/mtglib/internal/tls"
@@ -25,7 +26,7 @@ type Conn struct {
type connPayload struct {
ctx context.Context
ctxCancel context.CancelCauseFunc
clock Clock
stats Stats
wg sync.WaitGroup
writeStream bytes.Buffer
writtenCond sync.Cond
@@ -46,25 +47,23 @@ func (c Conn) Write(p []byte) (int, error) {
return len(p), context.Cause(c.p.ctx)
}
func (c Conn) Start() {
c.p.wg.Go(func() {
c.start()
})
}
func (c Conn) start() {
bp := doppelBufPool.Get().(*[]byte)
buf := *bp
defer doppelBufPool.Put(bp)
timer := time.NewTimer(c.p.stats.Delay())
defer timer.Stop()
for {
select {
case <-c.p.ctx.Done():
return
case <-c.p.clock.tick:
case <-timer.C:
timer.Reset(c.p.stats.Delay())
}
size := c.p.clock.stats.Size()
size := c.p.stats.Size()
c.p.writtenCond.L.Lock()
for c.p.writeStream.Len() == 0 && !c.p.done {
@@ -95,28 +94,22 @@ func (c Conn) Stop() {
c.p.wg.Wait()
}
func NewConn(ctx context.Context, conn essentials.Conn, stats *Stats) Conn {
func NewConn(ctx context.Context, conn essentials.Conn, stats Stats) Conn {
ctx, cancel := context.WithCancelCause(ctx)
rv := Conn{
Conn: conn,
p: &connPayload{
ctx: ctx,
ctxCancel: cancel,
stats: stats,
writtenCond: sync.Cond{
L: &sync.Mutex{},
},
clock: Clock{
stats: stats,
tick: make(chan struct{}),
},
},
}
rv.p.writeStream.Grow(tls.DefaultBufferSize)
rv.p.wg.Go(func() {
rv.p.clock.Start(ctx)
})
rv.p.wg.Go(func() {
rv.start()
})